04-07-2011, 05:17 PM
(04-07-2011, 04:01 PM)GrimFinger Wrote: So, what was the source of this particular bug or error? When my turn orders arrive (I send them the same way, each turn), are they in text format? Or do they arrive in HTML format?
I answered this in a reply to your email, but I'll include it here (with some edits) for the edification of others:
Email, in 2011, is much, much more complicated, and vastly different than it was in the 90s and early 00s. For this game (GA) I've been working on making the email processing robustly handle all the types of email players are sending me.
The orders you send from Outlook actually has two messages embedded in it. One is HTML and the other is plain text. My program has to specifically look for the plain text portion, and ignore the HTML portion. Thankfully it seems like Outlook Express does this as its default behavior. Some clients send HTML only.
(04-07-2011, 04:01 PM)GrimFinger Wrote: Is the bug in question in the Far Horizons code? Or is it in third-party software that you are using to fetch all of our turn orders from your e-mail in-box?Yes. No.
There is no 3rd party software involved in FH. The bug was simply a regression from an earlier bug fix. Technical details follow (and stringy code)
This was the offending commit that broke the orders fetcher.
This is the commit that fixed the regression. Turns out there was one case where decoding the payload was not a good idea: when the top most payload is not a message-part but in fact contains child payloads.